Commit-ID:  85a564d26dfb45bbf0c0095e0fcee3bdc4a49a85
Gitweb:     http://git.kernel.org/tip/85a564d26dfb45bbf0c0095e0fcee3bdc4a49a85
Author:     Adrian Hunter <[email protected]>
AuthorDate: Fri, 26 May 2017 11:17:30 +0300
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Fri, 30 Jun 2017 11:44:35 -0300

perf intel-pt: Tidy Intel PT evsel lookup into separate function

Tidy the lookup of the Intel PT selected event (perf_evsel) into a separate
function.

Signed-off-by: Adrian Hunter <[email protected]>
Cc: Andi Kleen <[email protected]>
Link: 
http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/util/intel-pt.c | 25 +++++++++++++++----------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/tools/perf/util/intel-pt.c b/tools/perf/util/intel-pt.c
index b670502..a9486b5 100644
--- a/tools/perf/util/intel-pt.c
+++ b/tools/perf/util/intel-pt.c
@@ -1922,24 +1922,29 @@ static int intel_pt_synth_event(struct perf_session 
*session,
                                           &id, intel_pt_event_synth);
 }
 
+static struct perf_evsel *intel_pt_evsel(struct intel_pt *pt,
+                                        struct perf_evlist *evlist)
+{
+       struct perf_evsel *evsel;
+
+       evlist__for_each_entry(evlist, evsel) {
+               if (evsel->attr.type == pt->pmu_type && evsel->ids)
+                       return evsel;
+       }
+
+       return NULL;
+}
+
 static int intel_pt_synth_events(struct intel_pt *pt,
                                 struct perf_session *session)
 {
        struct perf_evlist *evlist = session->evlist;
-       struct perf_evsel *evsel;
+       struct perf_evsel *evsel = intel_pt_evsel(pt, evlist);
        struct perf_event_attr attr;
-       bool found = false;
        u64 id;
        int err;
 
-       evlist__for_each_entry(evlist, evsel) {
-               if (evsel->attr.type == pt->pmu_type && evsel->ids) {
-                       found = true;
-                       break;
-               }
-       }
-
-       if (!found) {
+       if (!evsel) {
                pr_debug("There are no selected events with Intel Processor 
Trace data\n");
                return 0;
        }

Reply via email to