Re: [PATCH 19/21] x86/intel_rdt/mbm: Basic counting of MBM events (total and local)

[Thomas Gleixner]

On Mon, 26 Jun 2017, Vikas Shivappa wrote:
> +static struct mon_evt mbm_total_event = {
> +     .name = "mbm_total_bytes",
> +     .evtid = QOS_L3_MBM_TOTAL_EVENT_ID,
> +};
> +
> +static struct mon_evt mbm_local_event = {
> +     .name = "mbm_local_bytes",
> +     .evtid = QOS_L3_MBM_LOCAL_EVENT_ID,
> +};
> +
>  static void l3_mon_evt_init(struct rdt_resource *r)
>  {
>       INIT_LIST_HEAD(&r->evt_list);
>  
>       if (rdt_mon_features & (1 << QOS_L3_OCCUP_EVENT_ID))
>               list_add_tail(&llc_occupancy_event.list, &r->evt_list);
> +     if (is_mbm_total_enabled())
> +             list_add_tail(&mbm_total_event.list, &r->evt_list);
> +     if (is_mbm_local_enabled())
> +             list_add_tail(&mbm_local_event.list, &r->evt_list);

Confused. This hooks all monitoring features to RDT_RESOURCE_L3. Why?

Thanks,

        tglx