2017-07-05 5:47 GMT-07:00 Colin King <[email protected]>: > From: Colin Ian King <[email protected]> > > Currently oparms.create_options is uninitialized and the code is logically > or'ing in CREATE_OPEN_BACKUP_INTENT onto a garbage value of > oparms.create_options from the stack. Fix this by just setting the value > rather than or'ing in the setting. > > Detected by CoverityScan, CID#1447220 ("Unitialized scale value") > > Signed-off-by: Colin Ian King <[email protected]> > --- > fs/cifs/smb2ops.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c > index 941c40b7a870..c805b7619083 100644 > --- a/fs/cifs/smb2ops.c > +++ b/fs/cifs/smb2ops.c > @@ -1339,7 +1339,7 @@ get_smb2_acl_by_path(struct cifs_sb_info *cifs_sb, > xid = get_xid(); > > if (backup_cred(cifs_sb)) > - oparms.create_options |= CREATE_OPEN_BACKUP_INTENT; > + oparms.create_options = CREATE_OPEN_BACKUP_INTENT; > else > oparms.create_options = 0; >
Reviewed-by: Pavel Shilovsky <[email protected]> -- Best regards, Pavel Shilovsky
