On Wed, 5 Jul 2017 12:29:17 -0400
Steven Rostedt <rost...@goodmis.org> wrote:
> On Wed, 5 Jul 2017 12:25:06 -0400
> Steven Rostedt <rost...@goodmis.org> wrote:
>
>
> > > @@ -255,12 +262,18 @@ __run_test() { # testfile
> > > # Run one test case
> > > run_test() { # testfile
> > > local testname=`basename $1`
> > > - local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > + if [ "$LOG_FILE" ] ; then
> >
> > Shouldn't this be
> >
> > if [ ! -z "$LOG_FILE" ]; then
> >
> > ?
> >
>
> OK, I just checked it out. I guess "" is considered zero and
> "<anything>" is considered 1.
>
> Hmm, do we do this in other places too. Just makes me unconfortable.
OK, in that case, I can cleanup the code with [ ! -z "$VAR" ]
Thank you,
>
> -- Steve
>
--
Masami Hiramatsu <mhira...@kernel.org>
