On Wed, 5 Jul 2017 22:08:13 +0530 "Gautham R. Shenoy" <[email protected]> wrote:
> From: "Gautham R. Shenoy" <[email protected]> > > In the current idle initialization code, if there are failures in > pnv_probe_idle_states, then no platform idle state is > enabled. However, since the error is not propagated to the top-level > function pnv_init_idle_states, we continue initialization in this > top-level function even though this will never be used. > > Hence change the the return type of pnv_probe_idle_states from void to > int and in case of failures, bail out early on in > pnv_init_idle_states. > > Signed-off-by: Gautham R. Shenoy <[email protected]> Looks good to me. Reviewed-by: Nicholas Piggin <[email protected]> I wonder if the warnings are strong enough here to let people know idle won't be used so power consumption will be high and performance significantly reduced on SMT machines?
