hi Petr > I just noticed that the same applies also to text_len > variable. Well, it was caused by another commit ddb9baa822265b55 > ("printk: report lost messages in printk safe/nmi contexts"). > Could you please send a patch for this as well? sure and it is my pleasure.
> > This seems to be your first patch sent to the kernel mailing list. Yes :-) > There is a standard format how to reference older commits. It is > 'commit <12+ chars of sha1> ("<title line>")', see my comment above > for an example. > > A good practice is to run ./scripts/checkpatch.pl <patch> before > you send the patch. Well, you need to use a common sense and ignore > false positives or hints that make a particular patch less readable > in the end. > > Also it is handy to bump the version of the patch when it is > updated, e.g. use [PATCH v2] in the subject. People also > summarize changes against the previous version(s) below > the --- line. Well, this is more useful when there is a longer > delay between the versions and the changes are more complicated. Really appreciate hints you provided and I will send the v2 patch soon. Best Regards.