On 11/07/2017 at 09:58, Ludovic Desroches wrote: > On Tue, Jul 11, 2017 at 09:52:58AM +0200, Nicolas Ferre wrote: >> On 11/07/2017 at 09:40, Ludovic Desroches wrote: >>> A new compatible string has been introduced for sama5d2 SMC to allow to >>> manage the registers mapping change. >>> >>> Signed-off-by: Ludovic Desroches <[email protected]> >>> --- >>> arch/arm/boot/dts/sama5d2.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi >>> index 4fcd5bb219e3..60e69aeacbdb 100644 >>> --- a/arch/arm/boot/dts/sama5d2.dtsi >>> +++ b/arch/arm/boot/dts/sama5d2.dtsi >>> @@ -1048,7 +1048,7 @@ >>> }; >>> >>> hsmc: hsmc@f8014000 { >>> - compatible = "atmel,sama5d3-smc", "syscon", >>> "simple-mfd"; >>> + compatible = "atmel,sama5d2-smc", "syscon", >>> "simple-mfd"; >> >> You'd better use something like: >> compatible = "atmel,sama5d2-smc", "atmel,sama5d3-smc", "syscon", >> "simple-mfd"; > > But it's not true, during data interface setup, we will write values in > the wrong place if we fallback on "atmel,sama5d3-smc".
Yes, I wrote too quickly: sorry for the noise ;-) Bye, >> So that this patch is independent from the rest of the series and >> we can avoid to having to synchronize with mfd or mtd/nand for this part. >> >> Regards, >> >>> reg = <0xf8014000 0x1000>; >>> interrupts = <17 IRQ_TYPE_LEVEL_HIGH 6>; >>> clocks = <&hsmc_clk>; >>> >> >> >> -- >> Nicolas Ferre > -- Nicolas Ferre
