On Fri, Jul 14, 2017 at 02:46:32PM +0200, Johannes Thumshirn wrote:
> On Fri, Jul 14, 2017 at 02:32:08PM +0200, Christoph Hellwig wrote:
> > This patch itself looks good:
> >
> > Reviewed-by: Christoph Hellwig <h...@lst.de>
> >
> > > static struct configfs_attribute *nvmet_subsys_attrs[] = {
> > > &nvmet_subsys_attr_attr_allow_any_host,
> > > &nvmet_subsys_attr_version,
> > > + &nvmet_subsys_attr_attr_serial,
> >
> > but the new version attribute really needs the attr prefix so that
> > nvmetcli can pick it up. And we should also add nvmetcli support
> > for it. Can you do the rename before your series to ease backporting
> > as that should go into 3.12 (just like your serial number fix).
> >
>
> Is it OK if I send the patches in the same series?
Yes. Just move the version fix to the beginning, please.
