On Tue, Jul 18, 2017 at 09:36:04AM +0200, Quentin Schulz wrote: > >> + > >> + error = sysfs_create_group(&pdev->dev.kobj, > >> + axp20x_pek->attribute_group); > > > > Wouldn't it make more sense to just store the startup_time structure > > in the axp20x_pek structure, rather than duplicating all this? > > > > I don't know. Basically, you would need to recreate manually all the > structures in the probe function, but why not.
Why? You have access to axp20x_pek in the readout function. You can just use the table stored in the structure here, and just ignore any argument you might have. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
