On Thu, Jul 20, 2017 at 7:49 PM, Mark Salyzyn <[email protected]> wrote: > On 07/19/2017 06:38 PM, Rafael J. Wysocki wrote: >> >> From: Rafael J. Wysocki <[email protected]> >> >> Regardless of whether or not debug messages from the core system >> suspend/hibernation code are enabled, it is useful to know when >> system-wide transitions start and finish (or fail), so print "info" >> messages at these points. >> >> Signed-off-by: Rafael J. Wysocki <[email protected]> >> --- >> >> -> v2: Smiplified the messages as suggested by Mark. >> >> --- >> kernel/power/hibernate.c | 5 +++++ >> kernel/power/suspend.c | 2 ++ >> 2 files changed, 7 insertions(+) >> >> Index: linux-pm/kernel/power/hibernate.c >> =================================================================== >> --- linux-pm.orig/kernel/power/hibernate.c >> +++ linux-pm/kernel/power/hibernate.c >> @@ -692,6 +692,7 @@ int hibernate(void) >> goto Unlock; >> } >> + pr_info("hibernation entry\n"); > > nit (minor): Many of the logs report a PM: prefix. Flipping coin that the 3 > characters provides any real gain is in your hands. My WAG is it would be > nice to be able to do dmesg | grep PM:
Yeah, that's why pr_fmt() is defined in hibernate.c. It is missing in suspend.c ATM, though, hence the difference (but will be added there too). Thanks, Rafael
