Hi,

On 04-08-17 12:45, Peter Rosin wrote:
The redundant fb helpers .load_lut, .gamma_set and .gamma_get are
no longer used. Remove the dead code that was not doing anything
sensible anyway.

Signed-off-by: Peter Rosin <p...@axentia.se>

Thank you, patch looks good to me:

Acked-by: Hans de Goede <hdego...@redhat.com>

Regards,

Hans



---
  drivers/staging/vboxvideo/vbox_fb.c   | 15 ---------------
  drivers/staging/vboxvideo/vbox_mode.c |  5 -----
  2 files changed, 20 deletions(-)

[This time with an improved Cc list, sorry for the noise. For new
  people, please refer to https://lkml.org/lkml/2017/7/13/593 for
  context]

Hi Daniel,

Here it goes, but do you really need me to resend v5 14/14?

Cheers,
peda

diff --git a/drivers/staging/vboxvideo/vbox_fb.c 
b/drivers/staging/vboxvideo/vbox_fb.c
index 35f6d9f8c203..bf6635826159 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -317,22 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper,
        return 0;
  }
-static void vbox_fb_gamma_set(struct drm_crtc *crtc, u16 red, u16 green,
-                             u16 blue, int regno)
-{
-}
-
-static void vbox_fb_gamma_get(struct drm_crtc *crtc, u16 *red, u16 *green,
-                             u16 *blue, int regno)
-{
-       *red = regno;
-       *green = regno;
-       *blue = regno;
-}
-
  static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
-       .gamma_set = vbox_fb_gamma_set,
-       .gamma_get = vbox_fb_gamma_get,
        .fb_probe = vboxfb_create,
  };
diff --git a/drivers/staging/vboxvideo/vbox_mode.c b/drivers/staging/vboxvideo/vbox_mode.c
index f2b85f3256fa..996da1c79158 100644
--- a/drivers/staging/vboxvideo/vbox_mode.c
+++ b/drivers/staging/vboxvideo/vbox_mode.c
@@ -134,10 +134,6 @@ static int vbox_set_view(struct drm_crtc *crtc)
        return 0;
  }
-static void vbox_crtc_load_lut(struct drm_crtc *crtc)
-{
-}
-
  static void vbox_crtc_dpms(struct drm_crtc *crtc, int mode)
  {
        struct vbox_crtc *vbox_crtc = to_vbox_crtc(crtc);
@@ -330,7 +326,6 @@ static const struct drm_crtc_helper_funcs 
vbox_crtc_helper_funcs = {
        .mode_set = vbox_crtc_mode_set,
        /* .mode_set_base = vbox_crtc_mode_set_base, */
        .disable = vbox_crtc_disable,
-       .load_lut = vbox_crtc_load_lut,
        .prepare = vbox_crtc_prepare,
        .commit = vbox_crtc_commit,
  };

Reply via email to