On 04/08/17 23:10, Arnd Bergmann wrote:
How about linking the DML code into the mmci module and making that
Kconfig option a 'bool'?

Yes, I think making this bool and exporting the two symbols should fix this. It does not make sense to make dml helpers a module anyway.

If it sounds okay, I can send a proper patch to fix this.


diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index 5755b69..3345384 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -15,7 +15,7 @@ config MMC_ARMMMCI
          If unsure, say N.

 config MMC_QCOM_DML
-       tristate "Qualcomm Data Mover for SD Card Controller"
+       bool "Qualcomm Data Mover for SD Card Controller"
        depends on MMC_ARMMMCI && QCOM_BAM_DMA
        default y
diff --git a/drivers/mmc/host/mmci_qcom_dml.c b/drivers/mmc/host/mmci_qcom_dml.c
index 00750c9..e7d9c74 100644
--- a/drivers/mmc/host/mmci_qcom_dml.c
+++ b/drivers/mmc/host/mmci_qcom_dml.c
@@ -97,6 +97,7 @@ void dml_start_xfer(struct mmci_host *host, struct mmc_data *data)
        /* make sure the dml is configured before dma is triggered */

 static int of_get_dml_pipe_index(struct device_node *np, const char *name)
@@ -175,3 +176,4 @@ int dml_hw_init(struct mmci_host *host, struct device_node *np)

        return 0;


Reply via email to