Em Mon, Aug 07, 2017 at 09:22:08PM +0200, Milian Wolff escreveu: > On Montag, 7. August 2017 17:07:10 CEST Arnaldo Carvalho de Melo wrote: > > Em Sun, Aug 06, 2017 at 11:24:33PM +0200, Milian Wolff escreveu: > > > The follow-up commits will make inline frames first-class citizens > > > in the callchain, thereby obsoleting all of this special code.
> > So you are removing the feature to then reintroduce it, is that it? That > > is not usual :-\ > > Normally we go on replacing bit by bit or have some ifdef, etc, to then > > phase out the old code. > > Perhaps in this case your approach is the best one, still have to look > > at all of it, and it would help if the people behind the original code > > could review this, Yao Jin, can you take a look at this patch series, > > please? > Yes, I also did that in v1 of this patch series. Note that I can easily > squash > this, if needed. But I personally think for reviewing purposes, having it as > separate patches is far better. Well, if it is a full blown alternative implementation, like it seems to be (haven't started reviewing yet), probably. - Arnaldo
