From: Markus Elfring <elfr...@users.sourceforge.net>
Date: Wed, 9 Aug 2017 15:43:17 +0200

Move a function call into an else branch for successful function execution.
Omit a duplicate check for the local variable "result" then at the end.

Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net>
---
 drivers/acpi/acpi_video.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c
index 09ea1f115f55..8295ae1deab9 100644
--- a/drivers/acpi/acpi_video.c
+++ b/drivers/acpi/acpi_video.c
@@ -1422,14 +1422,12 @@ acpi_video_switch_brightness(struct work_struct *work)
        level_next = acpi_video_get_next_level(device, level_current, event);
 
        result = acpi_video_device_lcd_set_level(device, level_next);
-
-       if (!result)
-               backlight_force_update(device->backlight,
-                                      BACKLIGHT_UPDATE_HOTKEY);
-
 out:
        if (result)
                printk(KERN_ERR PREFIX "Failed to switch the brightness\n");
+       else
+               backlight_force_update(device->backlight,
+                                      BACKLIGHT_UPDATE_HOTKEY);
 }
 
 int acpi_video_get_edid(struct acpi_device *device, int type, int device_id,
-- 
2.13.4

Reply via email to