Hi James,

On 09/08/17 23:23, James Hogan wrote:
On 9 August 2017 10:35:39 BST, Harvey Hunt <harvey.h...@imgtec.com> wrote:
From: John Crispin <j...@phrozen.org>

Add a driver to setup the USB phy on Mediatek/Ralink SoCs.
The driver is trivial and only sets up power and host mode.

Signed-off-by: John Crispin <j...@phrozen.org>
Signed-off-by: Harvey Hunt <harvey.h...@imgtec.com>
Cc: linux-kernel@vger.kernel.org
Cc: linux-media...@lists.infradead.org
Changes in V4
* Remove Allwinner from comment
* Depend on COMPILE_TEST

Changes in V3
* Separate DT bindings
* Update Kconfig text
* Modify John's email address
* Rebase onto v4.13-rc3

Changes in V2
* remove refcounting
* drop empty functions
* dont use static globals
* use explicit compatible strings

drivers/phy/Kconfig          |   8 ++
drivers/phy/Makefile         |   1 +
drivers/phy/phy-ralink-usb.c | 173
3 files changed, 182 insertions(+)
create mode 100644 drivers/phy/phy-ralink-usb.c

diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
index c1807d4..8fb5260 100644
--- a/drivers/phy/Kconfig
+++ b/drivers/phy/Kconfig
@@ -41,6 +41,14 @@ config PHY_PISTACHIO_USB
          Enable this to support the USB2.0 PHY on the IMG Pistachio SoC.

+       tristate "Ralink USB PHY driver"
+       select GENERIC_PHY
+       depends on RALINK || COMPILE_TEST

given that the driver includes a asm/mach-ralink header, the COMPILE_TEST bit 
may break x86 allmodconfig?

maybe the header should be moved out of arch/mips or it should depend on MIPS 
only (so a mips allmodconfig catches it, but cant be enabled on x86 even with 



Well spotted - the build does indeed fail for ARCH=x86 allmodconfig.

I could either use:

depends on RALINK || (COMPILE_TEST && MIPS)

or just drop the COMPILE_TEST altogether, as I don't know how many people are running compile test only on MIPS.



Reply via email to