Le Wed, 9 Aug 2017 11:29:21 -0500,
"Gustavo A. R. Silva" <gust...@embeddedor.com> a écrit :
> platform_get_irq() returns an error code, but the sh_flctl
> driver ignores it and always returns -ENXIO. This is not correct
> and, prevents -EPROBE_DEFER from being propagated properly.
>
> Print and propagate the return value of platform_get_irq on failure.
>
> This issue was detected with the help of Coccinelle.
Applied.
Thanks,
Boris
>
> Signed-off-by: Gustavo A. R. Silva <gust...@embeddedor.com>
> ---
> drivers/mtd/nand/sh_flctl.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c
> index 891ac7b..7461b80 100644
> --- a/drivers/mtd/nand/sh_flctl.c
> +++ b/drivers/mtd/nand/sh_flctl.c
> @@ -1141,8 +1141,8 @@ static int flctl_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0) {
> - dev_err(&pdev->dev, "failed to get flste irq data\n");
> - return -ENXIO;
> + dev_err(&pdev->dev, "failed to get flste irq data: %d\n", irq);
> + return irq;
> }
>
> ret = devm_request_irq(&pdev->dev, irq, flctl_handle_flste, IRQF_SHARED,
