> -----Original Message----- > From: Tom Talpey > Sent: Monday, August 14, 2017 2:20 PM > To: Long Li <[email protected]>; Steve French <[email protected]>; > [email protected]; [email protected]; linux- > [email protected] > Subject: RE: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to > Makefile > > > -----Original Message----- > > From: [email protected] [mailto:linux-cifs- > > [email protected]] On Behalf Of Long Li > > Sent: Wednesday, August 2, 2017 4:11 PM > > To: Steve French <[email protected]>; [email protected]; > > samba- [email protected]; [email protected] > > Cc: Long Li <[email protected]> > > Subject: [[PATCH v1] 30/37] [CIFS] SMBD: Add SMBDirect transport to > > Makefile > > > > cifs-$(CONFIG_CIFS_SMB2) += smb2ops.o smb2maperror.o > smb2transport.o \ > > - smb2misc.o smb2pdu.o smb2inode.o smb2file.o > > + smb2misc.o smb2pdu.o smb2inode.o > > + smb2file.o cifsrdma.o > > "cifsrdma.o" is a really confusing choice of names. SMB Direct is only > possible > when the negotiated SMB dialect is SMB3. "CIFS" historically means a dialect > of SMB1, which many of us would like to see be in a separate, and therefore > omittable, module. Please use a name more indicative of the function, > perhaps "smbdirect.o".
Yes, I will make the naming changes. > > Tom.
