According to error handling in this function, it is likely that going to
'err_ulpi' was expected here.
Fixes: 605b8652f7f0 ("phy: Add support for Qualcomm's USB HSIC phy")
Signed-off-by: Christophe JAILLET <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
---
v2: rebase after commit 0b56e9a7e835 which has moved from
drivers/phy/phy-qcom-usb-hsic.c
to
drivers/phy/qualcomm/phy-qcom-usb-hsic.c
Reviewed-by tag can be found at https://lkml.org/lkml/2017/2/20/48
---
drivers/phy/qualcomm/phy-qcom-usb-hsic.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
index c110563a73cb..00926df4bc5b 100644
--- a/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
+++ b/drivers/phy/qualcomm/phy-qcom-usb-hsic.c
@@ -57,8 +57,10 @@ static int qcom_usb_hsic_phy_power_on(struct phy *phy)
/* Configure pins for HSIC functionality */
pins_default = pinctrl_lookup_state(uphy->pctl, PINCTRL_STATE_DEFAULT);
- if (IS_ERR(pins_default))
- return PTR_ERR(pins_default);
+ if (IS_ERR(pins_default)) {
+ ret = PTR_ERR(pins_default);
+ goto err_ulpi;
+ }
ret = pinctrl_select_state(uphy->pctl, pins_default);
if (ret)
--
2.11.0
