On Mon, Aug 21, 2017 at 9:31 PM, Danilo Krummrich
<[email protected]> wrote:

> +static int __ps2_gpio_write(struct serio *serio, unsigned char val)
> +static int ps2_gpio_write(struct serio *serio, unsigned char val)

I never like the random use of __prefixes as they have unclear
semantics.

I would name it something concise.

Anyways, that is up to the subsystem maintainer.
>From a GPIO point of view:
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij

Reply via email to