On Thu, 24 Aug 2017 10:06:03 +0900 Byungchul Park <[email protected]> wrote:
> Hello Steven, > > Can I keep your reviewed-by with comments modified? Yes, but I have one nit. > @@ -1668,9 +1691,35 @@ static int find_lowest_rq(struct task_struct *task) > return this_cpu; > } > > - best_cpu = cpumask_first_and(lowest_mask, > - sched_domain_span(sd)); > + /* > + * If a cpu being in lowest_mask & current sd & > + * ~prefer sd is valid, that becomes our choice. I can't parse the above sentence. -- Steve > + * Of course, the lowest possible cpu is already > + * under consideration through lowest_mask. > + */ > + best_cpu = find_cpu(lowest_mask, sd, prefer); > +
