On 9/13/17 9:10 AM, yuzhoujian wrote: > @@ -1621,8 +1634,12 @@ static int process_comm_event(struct perf_tool *tool, > sample->tid = event->comm.tid; > sample->pid = event->comm.pid; > } > - print_sample_start(sample, thread, evsel); > - perf_event__fprintf(event, stdout); > + if (tool->orientation_output == false) > + fp = stdout; > + else > + fp = orientation_file; > + fprint_sample_start(sample, thread, evsel, fp); > + perf_event__fprintf(event, fp); > ret = 0; > out: > thread__put(thread);
The subject of this patch is replacing printf and stdout with fprintf and a given fp. Please keep it to that one change. Meaning the above setting of fp something other than stdout should be a separate patch. And it would be best to have the fp selection in a helper, versus the same change in so many places.
