On Sun, 17 Sep 2017 16:13:52 +0200 Richard Weinberger <rich...@nod.at> wrote:
> header.major is of type u8 and cannot be negative. I guess you meant header.minor here. > > Detected by CoverityScan CID#1417858 ("Integer handling issues") > > Fixes: f384b352cbf0 ("mtd: spi-nor: parse Serial Flash Discoverable > Parameters (SFDP) tables") > Signed-off-by: Richard Weinberger <rich...@nod.at> > --- > Cyrille, > > I'm not sure what exactly you wanted to test. > Maybe it makes sense casting header.major to s8 before checking against < 0? > > Thanks, > //richard > --- > drivers/mtd/spi-nor/spi-nor.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index d71765739a93..4b86decdf13e 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2252,8 +2252,7 @@ static int spi_nor_parse_sfdp(struct spi_nor *nor, > > /* Check the SFDP header version. */ > if (le32_to_cpu(header.signature) != SFDP_SIGNATURE || > - header.major != SFDP_JESD216_MAJOR || > - header.minor < SFDP_JESD216_MINOR) > + header.major != SFDP_JESD216_MAJOR) > return -EINVAL; > > /*