On Thu, Sep 21, 2017 at 05:18:13PM +0100, Martyn Welch wrote: > From: Romain Perier <[email protected]> > > The variable dma_is_rxing is currently set to 1 in imx_disable_rx_int(). > This is problematic as: > > - whilst imx_disable_rx_int() is currently always called before > start_rx_dma() this dependency isn't obvious. > - start_rx_dma() does error checking and might exit without > enabling DMA. Currently this will result in dma_is_rxing suggesting > that DMA is being used for recieving. > > To avoid these issues, move the setting of dma_is_rxing to > start_rx_dma() when appropriate. > > Signed-off-by: Romain Perier <[email protected]> > Signed-off-by: Martyn Welch <[email protected]> Reviewed-by: Uwe Kleine-König <[email protected]>
Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |
