Em Fri, Sep 22, 2017 at 11:03:12AM +0200, Jiri Olsa escreveu:
> On Mon, Sep 18, 2017 at 01:55:20PM +0800, yuzhoujian wrote:
>
> SNIP
>
> > out_put:
> > addr_location__put(&al);
> > @@ -1605,6 +1617,7 @@ static int process_comm_event(struct perf_tool *tool,
> > struct perf_session *session = script->session;
> > struct perf_evsel *evsel = perf_evlist__id2evsel(session->evlist,
> > sample->id);
> > int ret = -1;
> > + FILE *fp;
> >
> > thread = machine__findnew_thread(machine, event->comm.pid,
> > event->comm.tid);
> > if (thread == NULL) {
> > @@ -1621,8 +1634,9 @@ static int process_comm_event(struct perf_tool *tool,
> > sample->tid = event->comm.tid;
> > sample->pid = event->comm.pid;
> > }
> > - print_sample_start(sample, thread, evsel);
> > - perf_event__fprintf(event, stdout);
> > + fp = stdout;
> > + fprint_sample_start(sample, thread, evsel, fp);
> > + perf_event__fprintf(event, fp);
>
> please make this simple 'adding fp argument to print functions'
> change and just pass stdout in here ... and do the rest of changes
> later on
That was what I asked him when I first reviewied this patchset.
- Arnaldo
