On 09/22/17 11:15, Geert Uytterhoeven wrote: > Hi Randy, > > On Fri, Sep 22, 2017 at 6:24 PM, Randy Dunlap <[email protected]> wrote: >> From: Randy Dunlap <[email protected]> >> >> Having the CHARLCD Kconfig symbol between "menuconfig AUXDISPLAY" >> and "if AUXDISPLAY" breaks the AUXDISPLAY submenus, so move the >> CHARLCD Kconfig symbol above the "menuconfig" so that the menu >> display is continuous. >> >> Fixes: 39f8ea46724e (auxdisplay: charlcd: Extract character LCD core from >> misc/panel) > > Oops, sorry for that. > >> Cc: [email protected] # v4.12 >> Cc: Geert Uytterhoeven <[email protected]> >> Cc: Miguel Ojeda Sandonis <[email protected]> >> Signed-off-by: Randy Dunlap <[email protected]> >> --- >> drivers/auxdisplay/Kconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> --- lnx-414-rc1.orig/drivers/auxdisplay/Kconfig >> +++ lnx-414-rc1/drivers/auxdisplay/Kconfig >> @@ -5,6 +5,9 @@ >> # Auxiliary display drivers configuration. >> # >> >> +config CHARLCD >> + tristate "Character LCD core support" if COMPILE_TEST >> + > > What about moving it inside (i.e. right below) the "if AUXDISPLAY" instead?
That works. But why? PANEL also selects CHARLCD, so it isn't specific to AUXDISPLAY. >> menuconfig AUXDISPLAY >> bool "Auxiliary Display support" >> ---help--- >> @@ -13,9 +16,6 @@ menuconfig AUXDISPLAY >> >> If you say N, all options in this submenu will be skipped and >> disabled. >> >> -config CHARLCD >> - tristate "Character LCD core support" if COMPILE_TEST >> - >> if AUXDISPLAY >> >> config HD44780 -- ~Randy
