Hi Linus, On 2017년 09월 24일 23:56, Linus Walleij wrote: > Nothing in the entire kernel #includes <linux/extcon/extcon-gpio.h> > so move the platform data declaration inside of the driver. > > Signed-off-by: Linus Walleij <[email protected]> > --- > drivers/extcon/extcon-gpio.c | 22 +++++++++++++++++- > include/linux/extcon/extcon-gpio.h | 47 > -------------------------------------- > 2 files changed, 21 insertions(+), 48 deletions(-) > delete mode 100644 include/linux/extcon/extcon-gpio.h > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index ebed22f22d75..6abf5f70fdbf 100644 > --- a/drivers/extcon/extcon-gpio.c > +++ b/drivers/extcon/extcon-gpio.c > @@ -18,7 +18,6 @@
Actually, extcon-gpio.h defines the 'struct gpio_extcon_pdata' in order to get the gpio and interrupt data from platform_data before device-tree binding method. But, as you mentioned, it is not used on kernel with platform_data method. Looks good to me. Acked-by: Chanwoo Choi <[email protected]> [snip] -- Best Regards, Chanwoo Choi Samsung Electronics
