On Mon, Sep 25, 2017 at 10:54 PM, Andrew Jeffery <[email protected]> wrote: > On Thu, 2017-09-21 at 13:56 +0930, Joel Stanley wrote: >> +static const u8 aspeed_resets[] = { >> + 25, /* x-dma */ >> + 24, /* mctp */ >> + 23, /* adc */ >> + 22, /* jtag-master */ >> + 18, /* mic */ >> + 9, /* pwm */ >> + 8, /* pci-vga */ >> + 2, /* i2c */ >> + 1, /* ahb */ > > Bit of a nit, but given you define macros for the indices, maybe use > designated > initialisers and drop the comments.
Done. And that way I'd notice that I missed the define for the ADC :) Cheers, Joel
