Thanks, Colin Ian King Acked-by: Wei Hu (Xavier) <xavier.hu...@huawei.com>
On 2017/9/30 4:13, Colin King wrote:
From: Colin Ian King <colin.k...@canonical.com> For the case where hr_qp->state == IB_QPS_RESET, an uninitialized value in ret is being returned by function hns_roce_v2_query_qp. Fix this by setting ret to 0 for this specific return condition. Detected by CoverityScan, CID#1457203 ("Unitialized scalar variable") Signed-off-by: Colin Ian King <colin.k...@canonical.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 4870b51caab9..791dae72e775 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -2805,6 +2805,7 @@ static int hns_roce_v2_query_qp(struct ib_qp *ibqp, struct ib_qp_attr *qp_attr,if (hr_qp->state == IB_QPS_RESET) {qp_attr->qp_state = IB_QPS_RESET; + ret = 0; goto done; }
