On 2017/10/10 上午5:54, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Cc: Kent Overstreet <[email protected]> > Cc: Shaohua Li <[email protected]> > Cc: [email protected] > Cc: [email protected] > Signed-off-by: Gustavo A. R. Silva <[email protected]>
It seems for gcc7, and -Wimplicit-fallthrough is equal to -Wimplicit-fallthrough=3, code comments work. Reviewed-by: Coly Li <[email protected]> Thanks. Coly > --- > drivers/md/bcache/util.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/md/bcache/util.c b/drivers/md/bcache/util.c > index 176d3c2..da9194b 100644 > --- a/drivers/md/bcache/util.c > +++ b/drivers/md/bcache/util.c > @@ -32,20 +32,27 @@ int bch_ ## name ## _h(const char *cp, type *res) > \ > case 'y': \ > case 'z': \ > u++; \ > + /* fall through */ \ > case 'e': \ > u++; \ > + /* fall through */ \ > case 'p': \ > u++; \ > + /* fall through */ \ > case 't': \ > u++; \ > + /* fall through */ \ > case 'g': \ > u++; \ > + /* fall through */ \ > case 'm': \ > u++; \ > + /* fall through */ \ > case 'k': \ > u++; \ > if (e++ == cp) \ > return -EINVAL; \ > + /* fall through */ \ > case '\n': \ > case '\0': \ > if (*e == '\n') \ >
