On Wed, Oct 11, 2017 at 6:38 AM, Vinod Koul <vinod.k...@intel.com> wrote: > On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org > wrote: >> + ctrl->pending_wr = kcalloc((ctrl->tx.n - 1), >> + sizeof(struct slim_pending), >> + GFP_KERNEL); >> + if (!ctrl->pending_wr) { >> + ret = -ENOMEM; >> + goto wr_alloc_failed; >> + } >> + >> + sema_init(&ctrl->tx_sem, (ctrl->tx.n - 1)); > > i though v5 comment from Arnd was not to use semaphores..
Right, these need to go away. Thanks for spotting it! Arnd