Hi, On Tuesday 10 October 2017 03:11 PM, Yoshihiro Shimoda wrote: > This patch modifies the role_store() to use "enum phy_mode" instead > of the local "bool" for host/device mode selection.
looks good except for one minor comment.. > > Signed-off-by: Yoshihiro Shimoda <[email protected]> > --- > drivers/phy/renesas/phy-rcar-gen3-usb2.c | 29 ++++++++++++++++++----------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c > b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > index e00e99a..7314b49 100644 > --- a/drivers/phy/renesas/phy-rcar-gen3-usb2.c > +++ b/drivers/phy/renesas/phy-rcar-gen3-usb2.c > @@ -219,33 +219,40 @@ static bool rcar_gen3_is_host(struct rcar_gen3_chan *ch) > return !(readl(ch->base + USB2_COMMCTRL) & USB2_COMMCTRL_OTG_PERI); > } > > +static enum phy_mode rcar_gen3_get_phy_mode(struct rcar_gen3_chan *ch) > +{ > + if (rcar_gen3_is_host(ch)) > + return PHY_MODE_USB_HOST; > + else the else here is not required. Thanks Kishon
