On Wed, Oct 11, 2017 at 11:56:23AM +0100, Colin King wrote: > From: Colin Ian King <[email protected]> > > Variable old_flags is being assigned but is never read; it is redundant > and can be removed. > > Cleans up clang warning: Value stored to 'old_flags' is never read > > Signed-off-by: Colin Ian King <[email protected]> > --- > kernel/bpf/cgroup.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/kernel/bpf/cgroup.c b/kernel/bpf/cgroup.c > index e88abc0865d5..3db5a17fcfe8 100644 > --- a/kernel/bpf/cgroup.c > +++ b/kernel/bpf/cgroup.c > @@ -192,7 +192,6 @@ int __cgroup_bpf_attach(struct cgroup *cgrp, struct > bpf_prog *prog, > struct cgroup_subsys_state *css; > struct bpf_prog_list *pl; > bool pl_was_allocated; > - u32 old_flags; > int err; > > if ((flags & BPF_F_ALLOW_OVERRIDE) && (flags & BPF_F_ALLOW_MULTI)) > @@ -239,7 +238,6 @@ int __cgroup_bpf_attach(struct cgroup *cgrp, struct > bpf_prog *prog, > pl->prog = prog; > } > > - old_flags = cgrp->bpf.flags[type];
Acked-by: Alexei Starovoitov <[email protected]> thanks for the cleanup. That was a leftover of one of the previous experiments I did. The patch is for net-next.
