On Mon, 2017-08-28 at 10:05 +0200, Greg Kroah-Hartman wrote: > 4.4-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Ronnie Sahlberg <[email protected]> > > commit d3edede29f74d335f81d95a4588f5f136a9f7dcf upstream. [...] > @@ -505,6 +506,11 @@ cifs_atomic_open(struct inode *inode, st > } > > tcon = tlink_tcon(tlink); > + > + rc = check_name(direntry, tcon); > + if (rc) > + goto out_free_xid; > + > server = tcon->ses->server; > > if (server->ops->new_lease_key) [...]
Doesn't this leak a reference to tlink? Seems like the exit label should be 'out' not 'out_free_xid'. Ben. -- Ben Hutchings Software Developer, Codethink Ltd.
