> -----Original Message----- > From: Eric Dumazet [mailto:[email protected]] > Sent: Tuesday, October 17, 2017 4:21 AM > To: Henrik Austad <[email protected]> > Cc: netdev <[email protected]>; David S . Miller > <[email protected]>; Daniel Borkmann <[email protected]>; David > Ahern <[email protected]>; Duyck, Alexander H > <[email protected]>; Willem de Bruijn <[email protected]>; > John Fastabend <[email protected]>; tcharding <[email protected]>; LKML > <[email protected]>; Henrik Austad <[email protected]>; Sanchez- > Palencia, Jesus <[email protected]> > Subject: Re: [PATCH] net: export netdev_txq_to_tc to allow sch_mqprio to > compile as module > > On Tue, Oct 17, 2017 at 3:10 AM, Henrik Austad <[email protected]> wrote: > > In commit 32302902ff09 ("mqprio: Reserve last 32 classid values for HW > > traffic classes and misc IDs") sch_mqprio started using > > netdev_txq_to_tc to find the correct tc instead of dev->tc_to_txq[] > > > > However, when mqprio is compiled as a module, it cannot resolve the > > symbol, leading to this error: > > > > ERROR: "netdev_txq_to_tc" [net/sched/sch_mqprio.ko] undefined! > > > > This adds an EXPORT_SYMBOL() since the other user in the kernel > > (netif_set_xps_queue) is also EXPORT_SYMBOL() (and not _GPL) or in a > > sysfs-callback. > > > > Cc: Alexander Duyck <[email protected]> > > Cc: Jesus Sanchez-Palencia <[email protected]> > > Cc: David S. Miller <[email protected]> > > Signed-off-by: Henrik Austad <[email protected]> > > > Reviewed-by: Eric Dumazet <[email protected]>
This is identical to a patch I submitted yesterday when I got the report from the kbuild robot. I would say your description looks much better than mine though so I would be good with dropping my patch in favor of this one. Acked-by: Alexander Duyck <[email protected]>
