On Monday 16 October 2017 14:48:37 Darren Hart wrote: > On Sun, Oct 15, 2017 at 06:03:14PM +0200, Pali Rohár wrote: > > This machine reports number of keyboard backlight led levels, instead of > > value of the last led level index. Therefore max_brightness properly needs > > to be subtracted by 1 to match led max_brightness API. > > Which field is behaving differently? > > If I'm understanding this correctly: > > Since the max level is something we test for once at runtime, it seems > to me a cleaner fix would be to check for this quirk in kbd_get_info() > and set kbd_info.levels accordingly. The rest of the driver logic would > then remain unchanged.
Great, this is a good idea. I would send a new patch in a few minutes. > The idea being to translate what the platform firmware reports into what > the driver already understands, instead of giving the levels fields of > the structure multiple meanings. -- Pali Rohár [email protected]
