Hi Joe, > -----Original Message----- > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Parav Pandit > Sent: Tuesday, October 10, 2017 5:44 PM > To: j...@perches.com; a...@canonical.com > Cc: linux-kernel@vger.kernel.org; linux-r...@vger.kernel.org; Parav Pandit > <pa...@mellanox.com>; Brad Erickson <brad...@mellanox.com> > Subject: [PATCH] checkpatch: Introduce check for format of Fixes line in > commit > log > > This patch introduces a format check for 'Fixes' line in commit log for 12 > characters commit id and format for Fixes as ("..."). > > Its created against linux-rdma Doug's tree [1]. > > [1] git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git > > Signed-off-by: Parav Pandit <pa...@mellanox.com> > Signed-off-by: Brad Erickson <brad...@mellanox.com> > --- > scripts/checkpatch.pl | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index > dd2c262..7d933e4 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2548,6 +2548,14 @@ sub process { > "Remove Gerrit Change-Id's before submitting > upstream.\n" . $herecurr); > } > > +# Check for incorrect format for Fixes line in commit log > + if ($in_commit_log && $line =~ /^\s*Fixes:/i) { > + if ($line !~ /^\s*Fixes: [a-z0-9]{12} \(\".*?\"\)$/i) { > + ERROR("FIXES_FORMAT", > + "Follow format of Fixes: <12 characters > commit id> (\"...\")\n" . $herecurr); > + } > + } > + > # Check if the commit log is in a possible stack dump > if ($in_commit_log && !$commit_log_possible_stack_dump && > ($line =~ /^\s*(?:WARNING:|BUG:)/ || > --
Did you get a chance to review this minor improvement patch? Does it look ok? Can it be pushed to Linux-rdma tree?
