On Thu 2017-10-19 19:48:15, Masahiro Yamada wrote: > Hi Petr, > > 2017-10-02 23:56 GMT+09:00 Petr Mladek <[email protected]>: > > On Mon 2017-09-18 00:01:44, Masahiro Yamada wrote: > >> Commit 069f0cd00df0 ("printk: Make the printk*once() variants return > >> a value") surrounded the macro implementation with ({ ... }). > >> > >> Now, the inner do { ... } while (0); is redundant. > >> > >> Signed-off-by: Masahiro Yamada <[email protected]> > > > > Looks fine to me. The return value is slightly more visible now ;-) > > > > Reviewed-by: Petr Mladek <[email protected]> > > > > JFYI, I have pushed it into for-4.15 branch. > > > > Best Regards, > > Petr > > > A minor problem. > > I think "Reviewed-by: " is missing before Sergey.
Great catch! Thanks for double checking! > I am not sure if this is too late, or not... Just pushed a fix. Best Regards, Petr
