On Thursday 03 May 2007, Paul Fulghum wrote: > >> + > >> + spin_lock_irqsave(&info->lock, flags); > > > > no need for _irqsave, just use spin_{,un}lock_irq() when you know that > > interrupts are enabled. > > That makes me a little uneasy. The locking > mechanisms (and just about everything else) above the driver > seem to change frequently. This involves not just the VFS but > the tty core as well. > > If you are confident this will not change, I will > switch to spin_lock(). I used spin_lock_irqsave() to be > more robust against changes to behavior outside my driver.
The same function contains a copy_from_user(), which cannot be called with interrupts disabled, so yes, I am very certain it will not change. Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/