On Tue, Oct 24, 2017 at 12:32 PM, Takashi Iwai <[email protected]> wrote: > On Tue, 24 Oct 2017 17:35:09 +0200, > Kees Cook wrote: >> >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer explicitly. >> >> Cc: Jaroslav Kysela <[email protected]> >> Cc: Takashi Iwai <[email protected]> >> Cc: Takashi Sakamoto <[email protected]> >> Cc: [email protected] >> Signed-off-by: Kees Cook <[email protected]> > > Thanks, applied. > > I guess we may deduce the card pointer from substream_output[], but > this approach will be simpler in the end.
Yeah, I looked at that as an option, and I couldn't tell if the lifetime might change out from under the timer, so I opted for an explicit pointer since that's no worse than what the old struct timer_list did anyway. :) Thanks! -Kees -- Kees Cook Pixel Security
