On Mon, Oct 30, 2017 at 10:27:10AM -0700, Matthias Kaehlcke wrote: > El Mon, Oct 30, 2017 at 09:26:12AM +0100 Peter Zijlstra ha dit: > > > On Fri, Oct 27, 2017 at 04:40:20PM -0700, Matthias Kaehlcke wrote: > > > The definition of sysctl_sched_migration_cost, sysctl_sched_nr_migrate > > > and sysctl_sched_time_avg includes the attribute const_debug. This > > > attribute is not part of the extern declaration of these variables in > > > include/linux/sched/sysctl.h, as a result clang generates warnings like > > > this: > > > > > > kernel/sched/sched.h:1618:33: warning: section attribute is specified on > > > redeclared variable [-Wsection] > > > extern const_debug unsigned int sysctl_sched_time_avg; > > > > Since they're already declared in sched/sysctl.h this redeclaration in > > sched/sched.h seems pointless. > > We could remove it, but it would require to move the definition of > const_debug to the 'globally' visible header sched/sysctl.h. Would > that be your preference? In that case we should probably use a more > unique name, like const_sched_debug.
Ah, I see; I got lost in the #ifdef maze. Yes you're right. Keep it like it is then.
