On 10/23/2017 01:42 AM, Sumit Semwal wrote: > The current mainline breakpoints test for arm64 fails to compile with > > breakpoint_test_arm64.c: In function ‘set_watchpoint’: > breakpoint_test_arm64.c:97:28: error: storage size of ‘dreg_state’ isn’t known > struct user_hwdebug_state dreg_state; > > Adding a direct include for asm/ptrace.h helps it to build, and passes > the test on mainline on hikey. > > Signed-off-by: Sumit Semwal <[email protected]> > --- > tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > index 960d02100c26..2d95e5adde72 100644 > --- a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > +++ b/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c > @@ -19,6 +19,7 @@ > > #define _GNU_SOURCE > > +#include <asm/ptrace.h> > #include <sys/types.h> > #include <sys/wait.h> > #include <sys/ptrace.h> >
Sumit, Thanks for the patch. I will queue this up for 4.15-rc1. This can be marked for stable I would assume? thanks, -- Shuah
