Serdev does not use the file abstraction and specifically there will
never be anyone polling a file descriptor for POLLOUT events.

Just use plain wake_up_interruptible() in the write_wakeup callback and
document why it's there.

Signed-off-by: Johan Hovold <[email protected]>
---
 drivers/tty/serdev/serdev-ttyport.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serdev/serdev-ttyport.c 
b/drivers/tty/serdev/serdev-ttyport.c
index 727664ef456c..ec07b903b7e5 100644
--- a/drivers/tty/serdev/serdev-ttyport.c
+++ b/drivers/tty/serdev/serdev-ttyport.c
@@ -67,7 +67,8 @@ static void ttyport_write_wakeup(struct tty_port *port)
            test_bit(SERPORT_ACTIVE, &serport->flags))
                serdev_controller_write_wakeup(ctrl);
 
-       wake_up_interruptible_poll(&tty->write_wait, POLLOUT);
+       /* Wake up any tty_wait_until_sent() */
+       wake_up_interruptible(&tty->write_wait);
 
        tty_kref_put(tty);
 }
-- 
2.15.0

Reply via email to