On Sun, Nov 5, 2017 at 7:38 AM, Johan Hovold <[email protected]> wrote: > On Tue, Oct 31, 2017 at 09:36:53AM -0700, Andrey Smirnov wrote: >> Add code implementing managed version of serdev_device_open() for >> serdev device drivers that "open" the device during driver's lifecycle >> only once (e.g. opened in .probe() and closed in .remove()). >> >> Cc: [email protected] >> Cc: [email protected] >> Cc: Rob Herring <[email protected]> >> Cc: [email protected] >> Cc: Guenter Roeck <[email protected]> >> Cc: Lucas Stach <[email protected]> >> Cc: Nikita Yushchenko <[email protected]> >> Cc: Lee Jones <[email protected]> >> Cc: Greg Kroah-Hartman <[email protected]> >> Cc: Pavel Machek <[email protected]> >> Cc: Andy Shevchenko <[email protected]> >> Cc: Johan Hovold <[email protected]> >> Cc: Sebastian Reichel <[email protected]> >> Reviewed-by: Sebastian Reichel <[email protected]> >> Reviewed-by: Guenter Roeck <[email protected]> >> Signed-off-by: Andrey Smirnov <[email protected]> >> --- >> Documentation/driver-model/devres.txt | 3 +++ >> drivers/tty/serdev/core.c | 27 +++++++++++++++++++++++++++ >> include/linux/serdev.h | 1 + >> 3 files changed, 31 insertions(+) > >> +int devm_serdev_device_open(struct device *dev, struct serdev_device >> *serdev) >> +{ >> + struct serdev_device **dr; >> + int ret; >> + >> + dr = devres_alloc(devm_serdev_device_release, sizeof(*dr), GFP_KERNEL); >> + if (!dr) >> + return -ENOMEM; >> + >> + ret = serdev_device_open(serdev); >> + if (ret) { >> + devres_free(dr); >> + return ret; >> + } >> + >> + *dr = serdev; >> + devres_add(dev, dr); >> + >> + return ret; > > This would be more readable as return 0.
Sure, I'll change that in v11. Thanks, Andrey Smrinov
