3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Andy Shevchenko <[email protected]>

commit 0d2c95354a3b63256e92d9fb865c08902d2c9b0b upstream.

The variable is used uninitialized which might come into unexpected
behaviour on some Samsung laptops.

Initialize it to 0xffff which seems a proper value for non-supported
feature.

Reported-by: Geert Uytterhoeven <[email protected]>
Signed-off-by: Andy Shevchenko <[email protected]>
Signed-off-by: Ben Hutchings <[email protected]>
---
 drivers/platform/x86/samsung-laptop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/platform/x86/samsung-laptop.c
+++ b/drivers/platform/x86/samsung-laptop.c
@@ -1347,9 +1347,9 @@ static int __init samsung_sabi_init(stru
        const struct sabi_config *config = NULL;
        const struct sabi_commands *commands;
        unsigned int ifaceP;
+       int loca = 0xffff;
        int ret = 0;
        int i;
-       int loca;
 
        samsung->f0000_segment = ioremap_nocache(0xf0000, 0xffff);
        if (!samsung->f0000_segment) {

Reply via email to