3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Timur Tabi <ti...@tabi.org>

commit acf2c60a60b3d6d7080854b9483f37d99ded9b23 upstream.

do_div() requires that the first parameter is a 64-bit integer,
which but clkrate was defined as an unsigned long.  This caused
the following warnings:

 CC      sound/soc/fsl/fsl_ssi.o
sound/soc/fsl/fsl_ssi.c: In function 'fsl_ssi_set_bclk':
sound/soc/fsl/fsl_ssi.c:593:3: warning: comparison of distinct pointer types 
lacks a cast
sound/soc/fsl/fsl_ssi.c:593:3: warning: right shift count >= width of type
sound/soc/fsl/fsl_ssi.c:593:3: warning: passing argument 1 of '__div64_32' from 
incompatible pointer type
include/asm-generic/div64.h:35:17: note: expected 'uint64_t *' but argument is 
of type 'long unsigned int *'

Signed-off-by: Timur Tabi <ti...@tabi.org>
Signed-off-by: Mark Brown <broo...@linaro.org>
Signed-off-by: Arnd Bergmann <a...@arndb.de>
Signed-off-by: Ben Hutchings <b...@decadent.org.uk>
---
 sound/soc/fsl/fsl_ssi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- a/sound/soc/fsl/fsl_ssi.c
+++ b/sound/soc/fsl/fsl_ssi.c
@@ -590,8 +590,8 @@ static int fsl_ssi_set_bclk(struct snd_p
                else
                        clkrate = clk_round_rate(ssi_private->baudclk, tmprate);
 
-               do_div(clkrate, factor);
-               afreq = (u32)clkrate / (i + 1);
+               clkrate /= factor;
+               afreq = clkrate / (i + 1);
 
                if (freq == afreq)
                        sub = 0;

Reply via email to