On Wed, Nov 08, 2017 at 08:39:11PM +0100, Christian Borntraeger wrote: > > > On 11/08/2017 08:35 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 08, 2017 at 07:57:28PM +0100, Christian Borntraeger wrote: > >> So what about the following > >> > >> - leave kvm_virtio.h unchanged and we will delete this file via the s390 > >> tree > > > > Seems to be used by kvm_virtio.c - are you removing that too? > > Yes, so sorry my first url for the git.kernel.org was in the wrong subfolder: > https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit?h=features&id=7fb2b2d512448cf0e914c4647a1cf02b52263702 > > > > > >> - change virtio_ccw.h to BSD license. The content of this file is really > >> really trivial > >> and it boils down to 2 defines, that can be easily reconstructed by > >> looking at the virtio spec. > >> Not even sure if something like this can be copyrighted. > > > > Yes. What prompted this was Greg's patch. > > > >> > >> For reference the content of this file minus comments is > >> > >> - snip - > >> #define KVM_VIRTIO_CCW_RING_ALIGN 4096 > >> #define KVM_S390_VIRTIO_CCW_NOTIFY 3 > >> - snip - > >> > >> > > [..]
So for ccw if both you and Cornelia ACK, we'll be fine I think. No one else touched this code. -- MST
