Hi Bjorn,
On Thu, Nov 09, 2017 at 09:00:16AM -0800, Bjorn Andersson wrote: > On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote: > > I think it's better to use the word "nodes" (add nodes...) Will reword that. > > > Signed-off-by: Damien Riegel <[email protected]> > > --- > > arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 72 > > ++++++++++++++++++++++++++++++ > > arch/arm64/boot/dts/qcom/msm8916.dtsi | 45 +++++++++++++++++++ > > 2 files changed, 117 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > index c67ad8ed8b60..1cec5b30ed6e 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8916-pins.dtsi > > @@ -270,6 +270,30 @@ > > }; > > }; > > > > + i2c1_default: i2c1_default { > > + pinmux { > > + function = "blsp_i2c1"; > > + pins = "gpio2", "gpio3"; > > + }; > > + pinconf { > > + pins = "gpio2", "gpio3"; > > + drive-strength = <16>; > > + bias-disable; > > + }; > > pinconf is typically board specific, so please leave these out from the > base dtsi. I don't mind dropping that, but pinconf for i2c{2,4,6} is already in msm8916-pins.dtsi, so we should either drop them all, or add pinconf for i2c{1,3,5} for consistency. And if I read the pinctrl driver correctly, I2C cannot be routed to other pins, the only properties that users may want to modify are drive-strength and bias. Let me know which option you prefer. > > diff --git a/arch/arm64/boot/dts/qcom/msm8916.dtsi > > b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > index de25bd6070f5..bdc4cb6f66d4 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8916.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8916.dtsi > > @@ -455,6 +455,21 @@ > > status = "disabled"; > > }; > > > > + blsp_i2c1: i2c@78b5000 { > > + compatible = "qcom,i2c-qup-v2.2.1"; > > + reg = <0x078b5000 0x600>; > > Size is 0x500. Will update that (and will also do that for patch 3) > > + interrupts = <GIC_SPI 95 0>; > > + clocks = <&gcc GCC_BLSP1_AHB_CLK>, > > + <&gcc GCC_BLSP1_QUP1_I2C_APPS_CLK>; > > + clock-names = "iface", "core"; > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&i2c1_default>; > > + pinctrl-1 = <&i2c1_sleep>; > > Please omit the pinctrl-* properties from the base dtsi (when it's not > hard coded things for the platform). > > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > blsp_i2c2: i2c@78b6000 { > > compatible = "qcom,i2c-qup-v2.2.1"; > > reg = <0x078b6000 0x600>; > > Otherwise this looks good! Thank you for the review, -- Damien
