On Thu, Nov 09, 2017 at 11:44:33PM +0100, Stefan Brüns wrote:
> Currently all key events use autorelease, but this forbids use as a
> modifier key.
>
> As all event codes come in even/odd pairs, we can lookup the key type
> (KE_KEY/KE_IGNORE) for the key up event corresponding to the currently
> handled key down event. If the key up is ignored, we keep setting the
> autorelease flag for the key down.
>
> Signed-off-by: Stefan Brüns <[email protected]>
+Dmitry, curious for your take on this approach.
>
> ---
>
> Changes in v2:
> - New patch, add support for seperate key up/down in intel-vbtn
>
> drivers/platform/x86/intel-vbtn.c | 17 +++++++++++++++--
> 1 file changed, 15 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/intel-vbtn.c
> b/drivers/platform/x86/intel-vbtn.c
> index ae55be91a64b..e3f6375af85c 100644
> --- a/drivers/platform/x86/intel-vbtn.c
> +++ b/drivers/platform/x86/intel-vbtn.c
> @@ -76,14 +76,27 @@ static void notify_handler(acpi_handle handle, u32 event,
> void *context)
> {
> struct platform_device *device = context;
> struct intel_vbtn_priv *priv = dev_get_drvdata(&device->dev);
> + const struct key_entry *ke_rel;
> + bool autorelease;
>
> if (priv->wakeup_mode) {
> if (sparse_keymap_entry_from_scancode(priv->input_dev, event)) {
> pm_wakeup_hard_event(&device->dev);
> return;
> }
> - } else if (sparse_keymap_report_event(priv->input_dev, event, 1, true))
> {
> - return;
> + } else {
> + /* Use the fact press/release come in even/odd pairs */
> + if ((event & 1) && sparse_keymap_report_event(priv->input_dev,
> + event, 0, false))
> + return;
> +
> + ke_rel = sparse_keymap_entry_from_scancode(priv->input_dev,
> + event | 1);
> + autorelease = !ke_rel || ke_rel->type == KE_IGNORE;
> +
> + if (sparse_keymap_report_event(priv->input_dev, event, 1,
> + autorelease))
> + return;
> }
> dev_dbg(&device->dev, "unknown event index 0x%x\n", event);
> }
> --
> 2.15.0
>
>
--
Darren Hart
VMware Open Source Technology Center
