Re: [PATCH v3 4/4] KVM: Add flush_on_enter before guest enter

[Wanpeng Li]

2017-11-10 18:07 GMT+08:00 Peter Zijlstra <pet...@infradead.org>:
> On Fri, Nov 10, 2017 at 01:49:47AM -0800, Wanpeng Li wrote:
>> @@ -2116,7 +2122,13 @@ static void record_steal_time(struct kvm_vcpu *vcpu)
>>               &vcpu->arch.st.steal, sizeof(struct kvm_steal_time))))
>>               return;
>>
>> +     if (xchg(&vcpu->arch.st.steal.preempted, KVM_VCPU_NOT_PREEMPTED) ==
>> +                     (KVM_VCPU_SHOULD_FLUSH | KVM_VCPU_PREEMPTED))
>> +             /*
>> +              * Do TLB_FLUSH before entering the guest, its passed
>> +              * the stage of request checking
>> +              */
>> +             kvm_vcpu_flush_tlb(vcpu, false);
>>
>
> Please add { } there.

Thanks for your review Peterz, I handle all your comments for this
patchset in v4, please have a look. :)

Regards,
Wanpeng Li