2017-11-10 18:21 GMT+09:00 Masahiro Yamada <[email protected]>: > Hi Cao, > > > 2017-11-10 17:45 GMT+09:00 Cao jin <[email protected]>: > >>> +ifneq ($(KBUILD_SRC),) >>> +# Create directories for object files if directory does not exist >>> +obj-dirs := $(sort $(obj) $(patsubst %/,%, $(dir $(targets)))) >>> +$(shell mkdir -p $(obj-dirs)) >>> +endif >>> + >> >> I just take a quick glance: is "$(obj)" here necessary? I think all >> $(targets) are under directory $(obj) when we descend into $(obj) to >> recursive make, if I don't miss anything. > > Good catch! > > I agree that $(obj) is unnecessary. > I will remove it if I see no problem in testing. > > Thanks!
I take back this comment. I was testing it, and in fact Kbuild failed to create modules.order due to missing $(obj) directory. -- Best Regards Masahiro Yamada
